src/integrationTest/java/com/ject/vs/vote/adapter/web/VoteApiIntegrationTest.java (2)

247-249: ⚡ Quick win

사용되지 않는 변수를 제거하세요.

responseBody 변수가 선언되었지만 사용되지 않습니다. 이 라인을 제거하거나, 응답에서 voteId를 파싱하여 사용하는 것이 일관성 있습니다.

♻️ 제안

-            // voteId 추출
-            String responseBody = createResult.getResponse().getContentAsString();
-            Long voteId = voteRepository.findAll().get(0).getId();
+            // voteId 추출
+            Long voteId = voteRepository.findAll().get(0).getId();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/integrationTest/java/com/ject/vs/vote/adapter/web/VoteApiIntegrationTest.java`
around lines 247 - 249, Remove the unused local variable responseBody declared
from createResult.getResponse().getContentAsString(); either delete that line or
replace its usage by parsing the created voteId from the response body and using
it instead of fetching voteRepository.findAll().get(0).getId(); update the test
to use the parsed voteId (from createResult) for subsequent assertions or remove
the unused responseBody altogether so only voteId (from either the response or
repository) remains in VoteApiIntegrationTest.

---

180-216: ⚡ Quick win

테스트 이름과 실제 검증 내용이 일치하지 않습니다.

테스트 이름은 "endAt이 정확히 계산된다"를 주장하지만, 실제로는 isNotEmpty()와 isNotNull()만 검증합니다. VoteRepositoryIntegrationTest처럼 각 duration에 대해 계산된 endAt 값을 명시적으로 검증해야 합니다.

♻️ 계산된 endAt 값을 검증하는 개선안

     `@Test`
-    `@DisplayName`("다양한 duration으로 투표 생성 시 endAt이 정확히 계산된다")
-    void 다양한_duration으로_투표_생성시_endAt_계산_확인() throws Exception {
+    `@DisplayName`("다양한 duration으로 투표 생성 시 endAt이 응답에 포함된다")
+    void 다양한_duration으로_투표_생성시_endAt_포함_확인() throws Exception {

또는 실제 계산 검증을 추가:

// 각 duration별로 endAt 차이를 검증
Map<String, Duration> durationMap = Map.of(
    "HOURS_1", Duration.ofHours(1),
    "HOURS_6", Duration.ofHours(6),
    "HOURS_12", Duration.ofHours(12),
    "HOURS_24", Duration.ofHours(24)
);

for (Vote vote : votes) {
    // title에서 duration 추출 후 endAt 차이 검증
    Instant expectedMinEndAt = vote.getCreatedAt().plus(durationMap.get(vote.getTitle().replace("투표 ", "")));
    assertThat(vote.getEndAt()).isAfterOrEqualTo(expectedMinEndAt);
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/integrationTest/java/com/ject/vs/vote/adapter/web/VoteApiIntegrationTest.java`
around lines 180 - 216, The test method 다양한_duration으로_투표_생성시_endAt_계산_확인() only
asserts presence of endAt but the name claims precise calculation; update the
test to compute expected durations and assert endAt is correctly computed per
vote. After creating votes with mockMvc in that test, build a Map<String,
Duration> for "HOURS_1","HOURS_6","HOURS_12","HOURS_24", load persisted Vote
entities via voteRepository.findAll(), extract the duration key from
vote.getTitle() (or from the request context), then assert
vote.getEndAt().isAfterOrEqualTo(vote.getCreatedAt().plus(expectedDuration)) (or
sufficiently close) for each Vote to validate exact endAt calculation rather
than only non-null checks. Ensure assertions reference the test method name
다양한_duration으로_투표_생성시_endAt_계산_확인, Vote.getCreatedAt(), and Vote.getEndAt().